Closed MeetDOD closed 4 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
style-share | ❌ Failed (Inspect) | Jun 30, 2024 10:15am |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊
@VaibhavArora314 @Ultimateutkarsh11 can you show me the logs for deployment failed :)
@VaibhavArora314 It's already have all the packages in dependencies !
I think it's because of the folder structure ?
@VaibhavArora314 It's already have all the packages in dependencies !
I think it's because of the folder structure ?
let me check and find some solutions
@VaibhavArora314 i think we should move admin folder to the frontend folder so it will use the frontend dependencies.
eg:
@VaibhavArora314 I moved all the admin logic to frontend only because creating 2 react apps does not make any sense also all the logic is written in admin folder also created admiauth atom store for same and backend is same.
now, please tell me why deployement is failed ?
@VaibhavArora314 I moved all the admin logic to frontend only because creating 2 react apps does not make any sense also all the logic is written in admin folder also created admiauth atom store for same and backend is same.
now, please tell me why deployement is failed ?
please don't move the logic of admin to frontend, as I want to separate their logic based on their usage. also, the reason deployment fails is because the express server is trying to admin react app but you deleted the whole admin app, so it isn't able to find it.
@VaibhavArora314 I moved all the admin logic to frontend only because creating 2 react apps does not make any sense also all the logic is written in admin folder also created admiauth atom store for same and backend is same. now, please tell me why deployement is failed ?
please don't move the logic of admin to frontend, as I want to separate their logic based on their usage. also, the reason deployment fails is because the express server is trying to admin react app but you deleted the whole admin app, so it isn't able to find it.
oops, sorry i will do the changes as it was previously. sorry for ininconvenience !
@VaibhavArora314 now tell me the issues, i did exactly what you told me to do !
@VaibhavArora314 I haven't worked on such project folder can you tell me in brief. how do i code in this folder and all or just update the readme file so that i could finish the work ASAP. It's a request from my side. Thank you !
I am thinking that you can split this task into two pull requests, one with backend logic and other with admin logic. Currently there are too many changes in this pull request and also I will be able to look into the reason as why there are dependency issues in the admin.
I am thinking that you can split this task into two pull requests, one with backend logic and other with admin logic. Currently there are too many changes in this pull request and also I will be able to look into the reason as why there are dependency issues in the admin.
@VaibhavArora314 i created issues for backend and frontend respectively you can close this one, i will start from new pr .
closing this since this is being continued in other pull requests and issues
Pull Request Resolves [#320 ]
Title: Created admin login backend and frontend successfully.
Description
Related Issues
Fixes #320
Changes Made
New features: Created admin login backend and frontend.
Screenshots
I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.
Thank You for this contribution.