VaibhavArora314 / StyleShare

A simple web based platform where users can easily create, explore, and share Tailwind CSS components and designs with fellow users.
https://style-share.vercel.app
MIT License
40 stars 68 forks source link

Feat: Added responsiveness in posts page successfully issue 336 #349

Closed MeetDOD closed 4 months ago

MeetDOD commented 4 months ago

Pull Request Resolves [#336 ]

Title: Added responsiveness in posts page successfully.

Description

  1. I used flex box and did justify between so that it divides it in two component like in one side filter, show trending button and on other side there is a search bar.
  2. The design is responsive in all devices respectively.

Related Issues

Fixes #336

Changes Made

New features: Added responsiveness in posts page.

Screenshots

image

image

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 10:16am
github-actions[bot] commented 4 months ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

akbatra567 commented 4 months ago

Seems to be good to me. In terms of responsiveness mentioned in the issue.

Note: It was not mentioned in the issue but seems a bit odd to me. @VaibhavArora314, Have a look.

Screenshot 2024-07-01 at 10 19 52 PM

MeetDOD commented 4 months ago

@akbatra567 Sir, your are also the mentor for style share webapp?

akbatra567 commented 4 months ago

@akbatra567 Sir, your are also the mentor for style share webapp?

Yes, recently been assigned. Trying to be more active.

MeetDOD commented 4 months ago

@akbatra567 Sir, your are also the mentor for style share webapp?

Yes, recently been assigned. Trying to be more active.

Nice to meet you sir 😀

VaibhavArora314 commented 4 months ago

Seems to be good to me. In terms of responsiveness mentioned in the issue.

Note: It was not mentioned in the issue but seems a bit odd to me. @VaibhavArora314, Have a look.

Screenshot 2024-07-01 at 10 19 52 PM

Yes we can create a separate issue for the navbar as the theme mode button looks odd on small devices

MeetDOD commented 4 months ago

@VaibhavArora314 I am working in admin folder but whenever i call api its give 404 error, i did npm run build but it still give that error only, did i have to configure something or any other command i have to run ?

Please help me !

github-actions[bot] commented 4 months ago

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

MeetDOD commented 4 months ago

@akbatra567 please add gssoc level

MeetDOD commented 4 months ago

@VaibhavArora314

@akbatra567 please add gssoc level

VaibhavArora314 commented 4 months ago

@VaibhavArora314 I am working in admin folder but whenever i call api its give 404 error, i did npm run build but it still give that error only, did i have to configure something or any other command i have to run ?

Please help me !

This should not be the case, have you uncommented the lines in app.tsx?

MeetDOD commented 4 months ago

@VaibhavArora314 I am working in admin folder but whenever i call api its give 404 error, i did npm run build but it still give that error only, did i have to configure something or any other command i have to run ? Please help me !

This should not be the case, have you uncommented the lines in app.tsx?

Ya I am running the app same as i am doing in frontend app.tsx, but still not working :(

MeetDOD commented 4 months ago

I am stuck in this

VaibhavArora314 commented 4 months ago

@VaibhavArora314 I am working in admin folder but whenever i call api its give 404 error, i did npm run build but it still give that error only, did i have to configure something or any other command i have to run ? Please help me !

This should not be the case, have you uncommented the lines in app.tsx?

Ya I am running the app same as i am doing in frontend app.tsx, but still not working :(

it may be due to the case of no such admin user exists where the status code returned was 404, I have updated the status code. also, make sure you are logging in with an account that has the isAdmin property set to true.