search

VaibhavCodeClub / learn

Learning app for kids
MIT License
88 stars 82 forks source link

Make SVG from alphabets page theme adaptive #14

Closed sapatevaibhav closed 4 months ago

sapatevaibhav commented 4 months ago

Is your feature request related to a problem? Please describe. Some of the SVGs are of black color.

Describe the solution you'd like When we change theme to the dark those SVGs must turn to other color (preferabely white).

Additional context Screenshot_20240510-151044

Prathme07 commented 4 months ago

Please assign it to me

kamalexe commented 4 months ago

Please assign me to this task I can solve using Theme.of(context).brightness == Brightness.dark;

Prathme07 commented 4 months ago

Actually if you use [Theme.of(context).brightness == Brightness.dark;] all the photos will come in white or black, and there orignal colors will be lost. I arleady worked on that and came to conlusion to give the conatiner color or prepare two versions of each svg for light and dark mode. That's why in my recent push I gave container there color

Shubham-Zone commented 4 months ago

i would like to contribute to this issue... kindly assign me i am GSSOC'24 contributor

sapatevaibhav commented 4 months ago

No need as background color is not black in dark mode too...