VaibhavCodeClub / learn

Learning app for kids
MIT License
81 stars 81 forks source link

Solar System Screen #18

Closed Prathme07 closed 1 month ago

Prathme07 commented 1 month ago

I have created the solar system screen but I am getting difficulty to navigate it to homescreen. Will you please see that and tell me what I have to do to correct that. And I will do that also so please don't it assign to anyone

sapatevaibhav commented 1 month ago
Prathme07 commented 1 month ago

@sapatevaibhav sorry I didn't see the changes that you adviced now I will do that

Prathme07 commented 1 month ago

@sapatevaibhav will you please recommend a site to convert png to svg. Cause which I am using either makes all black color or adding black background

sapatevaibhav commented 1 month ago

@sapatevaibhav will you please recommend a site to convert png to svg.

https://www.pngtosvg.com/ https://www.flaticon.com/ https://www.svgrepo.com/

sapatevaibhav commented 1 month ago
  • There isn't any need for main function in that page follow the approach same as other pages.

    • Do the essential changes to the drawer,

    • As well please go with the SVG files as they take less size try image to SVG converter.

First and 3rd thing is not implemented yet here is the code for planet page https://pastebin.com/VXjvXzvc as well from the drawer use

                Navigator.Named(context, AllRoutes.solarRoute);

instead of

                Navigator.pushReplacementNamed(context, AllRoutes.solarRoute);

Such that it doesn't stack as well add this page to home page too. If you have any doubt feel free to get in touch.

sapatevaibhav commented 1 month ago

Hello @Prathme07 just keep the solar related changes in this PR as it is conflicting with others.

Prathme07 commented 1 month ago

@sapatevaibhav please delete my A to Z screen push from here I don't know much about git so It happened. And please don't remove my solar scree

sapatevaibhav commented 1 month ago

Bro there isn't any need of closing PR as everyone here is for learning things so just keep doing you'll get a lot of things. If you are stuck everybody is here that is what open source is for. If you are raising another pull request for the same then you are most welcome here. 😊 As well focus on exams I'll reserve some issues specially for you. Keep learning and keep growing. 💪🏼

On Sat, May 11, 2024, 8:34 PM Prathmesh Chourasiya @.***> wrote:

@sapatevaibhav https://github.com/sapatevaibhav please delete my A to Z screen push from here I don't know much about git so It happened. And please don't remove my solar scree

— Reply to this email directly, view it on GitHub https://github.com/VaibhavCodeClub/learn/pull/18#issuecomment-2105926719, or unsubscribe https://github.com/notifications/unsubscribe-auth/APNC4AWJA3MJSKFE2EAA5I3ZBYXPVAVCNFSM6AAAAABHQ5VG2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVHEZDMNZRHE . You are receiving this because you were mentioned.

Message ID: @.***>