VaibhavCodeClub / learn

Learning app for kids
MIT License
88 stars 83 forks source link

Move all the models to a separate folder #97

Closed Maheen-Ilyas closed 4 months ago

Maheen-Ilyas commented 4 months ago

As the number of modules in the application are increasing, the model classes for the each module will also increase. We can create a models folder and move all the models into that folder. This will make the codebase clean and in the future, the contributors can make changes if needed with ease.

I am GSSoC'24 contributor. Please consider this.

xkaper001 commented 4 months ago

Hi Contributors and Mentors, I have already worked upon this issue and made a PR regarding this in #83 (merged already) Furthur

Hey @sapatevaibhav could you assign me and close this issue as completed.

Maheen-Ilyas commented 4 months ago

This issue is regarding these classes. class Bird { final String name; final String svgAsset; final String soundAsset; final Color backgroundColor;

Bird({ required this.name, required this.svgAsset, required this.soundAsset, required this.backgroundColor, }); }

xkaper001 commented 4 months ago

This issue is regarding these classes. class Bird { final String name; final String svgAsset; final String soundAsset; final Color backgroundColor;

Bird({ required this.name, required this.svgAsset, required this.soundAsset, required this.backgroundColor, }); }

could you elaborate

Maheen-Ilyas commented 4 months ago

This issue is regarding these classes. class Bird { final String name; final String svgAsset; final String soundAsset; final Color backgroundColor; Bird({ required this.name, required this.svgAsset, required this.soundAsset, required this.backgroundColor, }); }

could you elaborate

Each module has these classes. We can have a folder called models and move them to a separate file in the folder.

xkaper001 commented 4 months ago

Each module has these classes. We can have a folder called models and move them to a separate file in the folder.

check with the latest commit on master branch. I made a model folder with a module class in it and all the modules are placed in pages/modules (except the new ones being made by other contributors)

sapatevaibhav commented 4 months ago

112