search

VaibhavSaini19 / BootBlox

Ready-to-use Bootstrap CSS blocks
MIT License
26 stars 15 forks source link

Feat: Display thumbnail images dynamically #50

Closed erinknight242 closed 4 years ago

erinknight242 commented 4 years ago

What does this PR do?

Shows the thumbnails for that section if it exists, and the fallback image if not.

Screenshots (if applicable)

Screen Shot 2020-10-19 at 7 15 36 PM

Test Plan

Viewed index.html to confirm changes. In the screenshot above, the "contact" section is using the fallback image.

Related PRs and Issues

Resolves #35

Have you read the Contributing Guidelines?

yes

VaibhavSaini19 commented 4 years ago

@erinknight242 Can you rebase from master please. There was a small update

erinknight242 commented 4 years ago

@VaibhavSaini19 updated

VaibhavSaini19 commented 4 years ago

The ESLint action, unfortunately, handles only 50 annotations at max right now. Will merge even though the check fails. Will fix soon