ValMobile / RealisticSurvival

Realistic Survival - A unique Spigot/Paper plugin inspired by RLCraft that aims to enhance pure survival, adventuring and RPG, and immersion of vanilla Minecraft.
GNU General Public License v3.0
34 stars 14 forks source link

1.20.4 - Thirst saving with bigger amount of playerdata causes significant lag #47

Open jan-osicka opened 1 week ago

jan-osicka commented 1 week ago

❗ Checklist

📍 Description

When server actually uses this plugin it causes on versions 1.20.4 and 1.20.6 (these are tested, paper and purpur) the plugin is lagging the server due to saving of Thirst of players. Attaching log and also my player data from test server.

RSLag.log playerdata.zip

📑 Reproduction Steps

  1. Install new server with latest dev build.
  2. Generate at least 200 unique players (or 2000 for TPS drop to single digits)
  3. Wait for Thirst to save and update
  4. Watch on Spark RSV consuming all the resources trying to save the data (tested on VPS, shared host and local pc)

💡 Expected Behavior

I expected better saving of players data. At least save it async not in the main thread

📷 Screenshots / Videos

No response

📜 Server Log

No response

💻 Server Software

Purpur

🎮 Minecraft Version

1.20.x

⭐ Realistic Survival version

latest

🧭 Other plugins

none