Feature font awesome - Githubissues

ValYouW / jqPropertyGrid

A small property grid in JS to view/edit POJOs

MIT License

57 stars 33 forks source link

Feature font awesome #16

Closed gswilcox01 closed 7 years ago

gswilcox01 commented 7 years ago

Added options.useFontAwesome for the ?/help indicator.

I'm new to doing pull requests, so please let me know if i'm submitting them incorrectly. I wasn't sure exactly how to submit a 2nd one right away and am trying a feature branch in my fork to do it.

I ran "grunt" and got no errors:

$ grunt Running "jshint:files" (jshint) task

1 file lint free.

Running "jscs:files" (jscs) task

1 files without code style errors.

Thanks, --Gary

ValYouW commented 7 years ago

Hi,

Sorry for the late response... This could be a nice idea to customize the help icon, but I wouldn't want to be coupled to FontAwesome, so I think adding an helpHtml option would be nice, anyone could pass whatever html he like, Please keep this merge request only about that (I don't want to complicate this tiny lib with http-server etc). Thx.