ValdemarOrn / CloudSeed

Algorithmic Reverb VST Plugin
MIT License
427 stars 42 forks source link

Cast issue in CloudSeed.Native/MultitapDiffuser.h #9

Open EleonoreMizo opened 4 years ago

EleonoreMizo commented 4 years ago

Hi, I wanted to check the formula you used in CloudSeed to generate the early reflection taps. In MultitapDiffuser::Update(), there is a formula double tapCountFactor = 1.0 / (1 + std::sqrt(count / MaxTaps));. But it seems both count and MaxTaps are integer, so the division is done in integer land and returns 0 most of the times. Maybe casting count to double beforehand would give a more expected result?