ValdikSS / aceproxy

Ace Stream HTTP Proxy. ABANDONED! NO SUPPORT WHATSOEVER!
MIT License
196 stars 115 forks source link

P2pProxy plugin + some improvements #18

Closed ghost closed 9 years ago

ghost commented 9 years ago

What is this plugin for? It repeats the behavior of p2pproxy to support programs written for using p2pproxy

Some of examples for what you can use this plugin: Comfort TV widget (++ version) Official TorrentTV widget for Smart TV Kodi (XBMC) p2pproxy pvr plugin etc...

!!! It requires some changes in aceconfig.py: set the httpport to 8081 set the vlcoutport to some other port (8082 for example)

ValdikSS commented 9 years ago

Hi! Why did you close this pull request?

ghost commented 9 years ago

Hi there! Glad to hear from you. I am just wondering if my work needs to be merged in here. I want to continue the development and thought that making pull requests on every change is overdo. Want to hear your opinion :)

ghost commented 9 years ago

Now plugin is fully standalone.

ValdikSS commented 9 years ago

Wow-wow. I'll check everything asap.

ghost commented 9 years ago

Ok. That would be nice. Plugin is in development, so I thought to close request. But nevertheless it is stable so far so it can be merged. So waiting for your check.

ValdikSS commented 9 years ago

Would you mind if I reorganize/squash your commits?

ghost commented 9 years ago

Ok.

ValdikSS commented 9 years ago

By the way, you write:

if variable is None
or
if variable == ''

You can just always write:

if not variable
ghost commented 9 years ago

Thanks. I will keep that in mind. I am not very skillful in Python but already in love with it while writing plugin )

deseven commented 9 years ago

I'm afraid this is not just a "plugin" anymore :)

ghost commented 9 years ago

Yep :+1: There are also other changes to aceproxy. My aim is to make P2pProxy alternative, free of charge and open source.

ValdikSS commented 9 years ago

I'm not sure if we need tracebacks in log. It surely could be useful, but as for me, exception type and message is almost always sufficient.

ghost commented 9 years ago

So what about this? What else needs to be fixed\rewrote?

ValdikSS commented 9 years ago

Looks good for me. Thank you a loooot! You're the winner!

ghost commented 9 years ago

Yahoo! Thanks for appreciation. I think of what else I can do here...