search

ValeevGroup / BTAS

Basic Tensor Algebra Subroutines
http://itensor.org/btas
BSD 3-Clause "New" or "Revised" License
46 stars 19 forks source link

CMake fails regarding FetchWfn91LinAlgModules #142

Closed mbanck closed 1 year ago

mbanck commented 2 years ago 
CMake Error at external/linalgpp.cmake:3 (include):
  include could not find requested file:

    FetchWfn91LinAlgModules

If that file is not in an externally released project (I only see it in ValeevGroup/kit-cmake), it should be vendored it (or rather the repo it tries to checkout) I guess?

evaleev commented 1 year ago

@mbanck https://github.com/ValeevGroup/BTAS/pull/149/commits/0d24af89a08b3ef99acd5b082fc2e174be32f2ec makes it clearer where this file is coming from ... indeed from https://github.com/ValeevGroup/kit-cmake

Presumably the cmake kit needs to be packaged properly? It lacks the standard packaging boilerplate (install etc.) since due to limitations of cmake it was always designed to be FetchContented into BTAS' (and other VG project) source tree rather than discovered via find_package/find_dependency ...

mbanck commented 1 year ago

Yeah, I went that route in the meantime