ValenciaLim / pe

0 stars 0 forks source link

Wrong error message for checking invalid prefix #10

Open ValenciaLim opened 2 months ago

ValenciaLim commented 2 months ago

add cn/Google n/Sam p/98765432 z/ e/johnd@example.com a/311, Clementi Ave 2. Check for invalid prefix and display appropriate error message. This wrong error message will confuse the user and make it more difficult for user to identify the mistake.

image.png

soc-pe-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Does not check for invalid prefix

add cn/Google n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2 z/. This is added successfully even though it contained invalid prefix z/.

image.png


[original: nus-cs2103-AY2324S2/pe-interim#3433] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for raising this issue. While we acknowledge that this may cause confusion to some users, it is unlikely that adding an invalid prefix into an address section would cause inconvenicnce to some users. Addressing this particular issue is currently not within our scope due to existing project priorities and resource constraints. Our team is currently focused on addressing critical bugs and implementing essential features to enhance user experience. However, we have noted your feedback and will consider it for future updates. Thank you for your understanding.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** Since the team is working with a CLI-based application, it is very possible for users to input invalid prefix due to a slip of the mind. Especially so, since the team has a long list of prefixes. Hence, this is an essential feature that should be fixed to enhance user experience.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** This is a functionality bug as the behaviour differs from normal expectation, in this case, the error message does not match the error.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]