search

ValenciaLim / pe

0 stars 0 forks source link

Does not check for invalid prefix #9

Open ValenciaLim opened 2 months ago

ValenciaLim commented 2 months ago

add cn/Google n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2 z/. This is added successfully even though it contained invalid prefix z/.

image.png

nus-pe-bot commented 2 months ago

Team's Response

Thank you for raising this issue. While we acknowledge that this may cause confusion to some users, it is unlikely that adding an invalid prefix into an address section would cause inconvenicnce to some users. Addressing this particular issue is currently not within our scope due to existing project priorities and resource constraints. Our team is currently focused on addressing critical bugs and implementing essential features to enhance user experience. However, we have noted your feedback and will consider it for future updates. Thank you for your understanding.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Since the team is working with a CLI-based application, it is very possible for users to input invalid prefix due to a slip of the mind. Especially so, since the team has a long list of prefixes. Hence, this is an essential feature that should be fixed to enhance user experience.

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** This is a functionality bug as a legitimate behaviour, in this case, user inputting invalid prefix, is not handled.