Jabber; state always "on the phone" with not the real status or statusmessage

GoogleCodeExporter commented 8 years ago

Miranda Version                  : v0.10.10.0
Unicode Build                    : Yes
Test Build # (if applicable)     : N/A
Plugin Version # (if applicable) : N/A

What steps will reproduce the problem?
1. Going online with my android phone with the app xabber
2. Going online with miranda
3. Look at xabber at the contact list at my own contact, i am online, no mood 
or acticity set (picture one)
4. Going to miranda, look at the contactlist, there is the state "on the phone" 
no message, no other state, it doesn't matter in which state my phone is (in 
xabber) (picture two)
5. I can't read or see any online message or state or change state of my phone 
in miranda (picture three)

In miranda version 8.8. the issue was not there, it worked perfectly.

VersionInfo:

CPU: AMD FX(tm)-8120 Eight-Core Processor  [AMD64 Family 21 Model 1 Stepping 2] 
[DEP Enabled] [8 CPUs]
Installed RAM: 16330 MBytes
Operating System: Microsoft Windows 8, 64-bit (build 9200)
Internet Explorer: 9.10.9200.16484 (build 99200)
Administrator privileges: No
OS Languages: (UI | Locale (User/System)) : German/German | German/German
Free disk space on Miranda partition: 399491 MBytes

Miranda IM Version: 0.10.10.0 Unicode [running inside WOW64]
Build time: 2013-02-11 02:15:33+0100
Profile: D:\Miranda\Profiles\home\home.dat
Profile size: 47316992 Bytes
Profile creation date: 2010-10-18 10:53:41+0100
Language pack: No language pack installed
Nightly: No
Unicode: Yes
Service Mode: No

Active Plugins (28):
¤ advaimg.dll v.0.10.10.0 [2013-02-11 02:12:47+0100] - Miranda Image services 
¤ Aim.dll v.0.10.10.0 [2013-02-11 02:13:31+0100] - AIM Protocol |Unicode aware|
  alicebot.dll v.0.0.0.4 [2003-04-11 00:05:26+0100] - Anna the Alicebot 
¤ AutoReplacer.dll v.0.0.1.7 [2008-05-03 19:01:46+0100] - AutoReplacer 
¤ avs.dll v.0.10.10.0 [2013-02-11 02:13:42+0100] - Avatar service (Unicode) 
|Unicode aware|
¤ chat.dll v.0.10.10.0 [2013-02-11 02:13:55+0100] - Chat |Unicode aware|
¤ clist_modern.dll v.0.9.0.11 [2013-02-11 02:15:54+0100] - Modern Contact List 
'09 |Unicode aware|
¤ contacts.dll v.1.5.2.0 [2008-07-27 13:05:20+0100] - Send/Receive Contacts+ 
|Unicode aware|
¤ cryptopp.dll v.1.0.4.3 [2009-05-18 15:06:04+0100] - Crypto++ 
¤ dbx_mmap.dll v.0.10.10.0 [2013-02-11 02:14:16+0100] - Miranda mmap database 
driver |Unicode aware|
¤ facebook.dll v.0.1.3.10 [2011-04-30 16:26:48+0100] - Facebook Protocol 
|Unicode aware|
¤ historypp.dll v.1.5.1.4 [2010-02-23 18:16:24+0100] - History++ (2in1) 
|Unicode aware|
¤ icq.dll v.0.10.10.0 [2013-02-11 02:14:45+0100] - IcqOscarJ Protocol |Unicode 
aware|
¤ import.dll v.0.10.10.0 [2013-02-11 02:14:47+0100] - Import contacts and 
messages |Unicode aware|
¤ IRC.dll v.0.10.10.0 [2013-02-11 02:13:07+0100] - IRC protocol |Unicode aware|
¤ jabber.dll v.0.10.10.0 [2013-02-11 02:15:11+0100] - Jabber Protocol |Unicode 
aware|
¤ KeepStatus.dll v.0.8.0.96 [2010-08-22 13:53:52+0100] - KeepStatus (Unicode) 
|Unicode aware|
¤ LogServiceW.dll v.0.1.0.1 [2007-11-14 16:03:00+0100] - LogService (Unicode) 
|Unicode aware|
¤ msn.dll v.0.10.10.0 [2013-02-11 02:16:12+0100] - MSN Protocol |Unicode aware|
¤ NewAwaySysW.dll v.0.3.8.2 [2007-10-13 13:56:34+0100] - New Away System 
(Unicode) |Unicode aware|
¤ nudge.dll v.0.0.1.19 [2008-04-21 09:51:52+0100] - Nudge |Unicode aware|
¤ pingproto.dll v.0.5.0.2 [2007-05-24 15:34:22+0100] - Ping Protocol 
  PopUp.dll v.2.0.3.8 [2004-09-21 18:19:28+0100] - PopUp Interoperability 
¤ scriver.dll v.2.10.0.2 [2013-02-11 02:16:27+0100] - Scriver (Unicode) 
|Unicode aware|
¤ secureim.dll v.1.0.12.4 [2010-04-28 09:41:18+0100] - SecureIM (2in1) 
¤ svc_crshdmp.dll v.0.0.4.19 [2011-01-01 15:48:06+0100] - Crash Dumper Unicode 
|Unicode aware|
¤ Variables.dll v.0.2.3.8 [2010-06-16 21:48:54+0100] - Variables (Unicode) 
|Unicode aware|
¤ WhenWasIt.dll v.0.3.2.5 [2010-05-19 10:59:48+0100] - WhenWasIt birthday 
reminder (Unicode) |Unicode aware|

Unloadable Plugins (2):
  dbx_3x.dll v.0.0.0.0 [2009-01-05 17:57:00+0100] - <unknown> 
    This dll is a Miranda database plugin, another database is active right now

  msg_export.dll v.0.0.0.0 [2006-02-17 22:45:10+0100] - <unknown> 

Protocols and Accounts:
-------------------------------------------------------------------------------
AIM                      0 - Enabled 0 - Disabled  Loaded
Facebook                 0 - Enabled 1 - Disabled  Loaded
ICQ                      1 - Enabled 0 - Disabled  Loaded
IRC                      0 - Enabled 0 - Disabled  Loaded
JABBER                   1 - Enabled 1 - Disabled  Loaded
MSN                      1 - Enabled 0 - Disabled  Loaded
PING                     1 - Enabled 0 - Disabled  Loaded

Icon Packs:
-------------------------------------------------------------------------------
 historypp_icons.dll [2010-02-23 18:16:26+0100]
 jabber_xstatus.dll [2008-07-11 01:18:06+0100]
 proto_AIM.dll [2012-10-25 01:01:23+0100]
 proto_conn_facebook.dll [2007-12-10 08:51:26+0100]
 proto_facebook.dll [2009-06-02 10:06:22+0100]
 proto_GG.dll [2012-10-25 01:01:24+0100]
 proto_ICQ.dll [2012-10-25 01:01:24+0100]
 proto_IRC.dll [2012-10-25 01:01:25+0100]
 proto_JABBER.dll [2012-10-25 01:01:25+0100]
 proto_MSN.dll [2012-10-25 01:01:26+0100]
 proto_YAHOO.dll [2012-10-25 01:01:27+0100]
 secureim_icons.dll [2009-05-07 12:41:54+0100]
 tabsrmm_icons.dll [2013-02-11 02:12:59+0100]
 toolbar_icons.dll [2013-02-11 02:12:59+0100]
 xstatus_icons.dll [2006-07-18 01:09:06+0100]
 xstatus_ICQ.dll [2013-02-11 02:12:58+0100]
 xstatus_jabber.dll [2013-02-11 02:13:12+0100]

Original issue reported on code.google.com by paulepop...@gmail.com on 18 Feb 2013 at 11:37

Attachments:

GoogleCodeExporter commented 8 years ago

Hi!

As I understand, the problem is that button "Read Online/Away/Whatever Message" 
is missing for contacts on the phone. Is that correct?

I would like to look at it and possibly fix this. Can someone confirm that it 
is a bug (not a "feature").

Jakub

Original comment by kub...@gmail.com on 25 Feb 2013 at 8:23

GoogleCodeExporter commented 8 years ago

Can you give some more info about this issue please?

1. Does it concern only your mobile contact or all mobile contacts in general?
2. What is the expected result? I assume, that is expected behaviour:
        - Real mood status in contact window (e.g. "On the phone - DND")
        - Corresponding icon change in main window according to mood status
        - Ability to read status message through right click menu
3. In relation to point 5 "I can't read or see any online message or state or 
change state of my phone in miranda ". How does it differ from "non-mobile" 
contacts, how exactly do you try to read this online message.

thank you

Original comment by kub...@gmail.com on 27 Feb 2013 at 5:30

GoogleCodeExporter commented 8 years ago

Hello,

one of the contacts (which is shown as "on the phone" and online with xabber) 
in the Screenshot_2013-02-19-00-12-15_PC_001.png (below "me") should be "away" 
but it is not shown as away, and there is no online/away/NA etc. message. The 
contact below this contact should be online, but the same happens here, no 
online message, no status but "on the phone".

"As I understand, the problem is that button "Read Online/Away/Whatever 
Message" is missing for contacts on the phone. Is that correct?" -> yes, that 
button is missing too.

1. that happens with all jabber contacts, logged in by phone (xabber)

2.1 there is no mood set by the phone.
2.2 i can't set any mood on my phone, or do you mean if the mood is shown at 
the contact list when an other client (not a phone) sets a mood?
2.3 i can read every status message of every contact, except the jabber 
contacts, online by phone (xabber)

3. the online message, only of mobile contacts is not shown in my contactlist 
and not shown in my chat window. i tried to read the online message with in the 
contact menu, but there is no menu-point in the contact menu "read online 
message". (i explained above point one)

xabber wasn't updatet and with older versions of miranda, this bug does not 
happen. There was no "on the phone" mood, there was only the status 
(online/away/NA etc.) with the correct message.

If you want you can have a test account on my server to see what happens, or i 
can make a video while the error is happening.

* xabber = android jabber app

greetings :-)

Original comment by paulepop...@gmail.com on 27 Feb 2013 at 11:24

GoogleCodeExporter commented 8 years ago

thank you very much for your detailed description. I will look at it and 
hopefully come with some patch soon ;-)

Original comment by kub...@gmail.com on 5 Mar 2013 at 11:33

GoogleCodeExporter commented 8 years ago

m_protosvc.h, PFLAGNUM_3, PF2_ONTHEPHONE

Original comment by wishmaster51 on 8 Mar 2013 at 8:27

GoogleCodeExporter commented 8 years ago

[cite]m_protosvc.h, PFLAGNUM_3, PF2_ONTHEPHONE[/cite]

wow....

so here (see attachement) is the patch to show "Read ??? Message" button in 
right click menu for on the phone contacts

Jakub Boksansky

Original comment by kub...@gmail.com on 9 Mar 2013 at 7:05

GoogleCodeExporter commented 8 years ago

I didnt test it, but it looks right :) Why dont you test it yourself?

Original comment by wishmaster51 on 9 Mar 2013 at 7:08

GoogleCodeExporter commented 8 years ago

tested:) It works no problem. Is there a chance, this gets commited to main 
repo? ;-)

Original comment by kub...@gmail.com on 11 Mar 2013 at 12:29

GoogleCodeExporter commented 8 years ago

Sure it can. You may send it to rainwater with email directly though.

Original comment by wishmaster51 on 11 Mar 2013 at 6:50

GoogleCodeExporter commented 8 years ago

Sent it to rainwater, but he doesnt respond, I guess hes busy or something. 
When is next miranda release scheduled? Maybe you can commit this to 
miranda-sources if you are a commiter?

Original comment by kub...@gmail.com on 14 Mar 2013 at 6:08

GoogleCodeExporter commented 8 years ago

No Im not a committer, otherwise I would have already fixed it. rainwater is 
doing all the releases though, so he will propably merge it.

Original comment by wishmaster51 on 14 Mar 2013 at 8:22

GoogleCodeExporter commented 8 years ago

Fixed in SVN.

Original comment by rainwater on 14 Mar 2013 at 11:01

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

This issue was closed by revision r14410.

Original comment by rainwater on 14 Mar 2013 at 11:12

ValentijnNK / miranda

Jabber; state always "on the phone" with not the real status or statusmessage #1695