ValentijnNK / miranda

Automatically exported from code.google.com/p/miranda
0 stars 0 forks source link

Fix for crash of ICQ plugin due server group list was not obtained #1698

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
szActiveSrvGroup can be NULL so it crashes in _strnicmp(). Here is a fix:

Index: fam_13servclist.cpp
===================================================================
--- fam_13servclist.cpp (revision 14409)
+++ fam_13servclist.cpp (working copy)
@@ -963,7 +963,7 @@
                        }

                        if (strcmpnull(szActiveSrvGroup, szLocalGroup) && 
-                           (strlennull(szActiveSrvGroup) >= strlennull(szLocalGroup) || 
_strnicmp(szActiveSrvGroup, szLocalGroup, strlennull(szLocalGroup))))
+                           (strlennull(szActiveSrvGroup) >= strlennull(szLocalGroup) || ( 
szActiveSrvGroup && _strnicmp(szActiveSrvGroup, szLocalGroup, 
strlennull(szLocalGroup)))))
                        { // contact moved to new group or sub-group or not to master group
                            bRegroup = 1;
                        }

Original issue reported on code.google.com by ryo.rab...@gmail.com on 1 Mar 2013 at 2:33

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed in SVN.

Original comment by rainwater on 14 Mar 2013 at 11:13

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r14411.

Original comment by rainwater on 14 Mar 2013 at 11:27