Bug with caps in jabber plugin

[GoogleCodeExporter]

Miranda Version                  : 0.10.17
Unicode Build                    : Yes
Test Build # (if applicable)     :
Plugin Version # (if applicable) : jabber.dll 0.10.17

What steps will reproduce the problem?
1. Run two miranda clients with jabber plugin active on two computers. Connect 
to jabber server and activate "Send messages slower, but with full 
acknowledgement" on them. Set both to online.
2. Unplug cord from computer one. In jabber contact list of computer two user 
one remains online. Send message to them.
3. There is no warning, that message wasn't send, thow user one in fact hadn't 
recieved it.

What is the expected result?
We expect, that option "Send messages slower, but with full acknowledgement" 
guarantees, that message will reach user, or error appears. It is not so.

This error has nothing to do with options. If you log netlib information to 
file, you will see, that Caps are broken, for example it prints 
0x8000000000000003, or just "1", which seems to be not correct. Problem 
appears, if you have only one resource for current jid in roster. The reason is 
in jabber_list.cpp, string 351 
(http://code.google.com/p/miranda/source/browse/trunk/miranda/protocols/JabberG/
jabber_list.cpp#351). If LI->resourceCount will be equal to 1, res will remain 
NULL, and ListGetBestResourceNamePtr will return NULL, 
CJabberProto::GetClientJID will return name without resource, and 
GetResourceCapabilites will return error.
This seems to be bug of all 0.10.x line. At least 0.9.36 doesnt't have this 
problem. It has string
    if ( !res && LI->resource)
        res = LI->resource[0].resourceName;
after the condition if ( LI->resourceCount > 1 ).
I added this string, but it didn't work; then changing the condition if ( 
LI->resourceCount >= 1 ) helped.
The problem appeared both in x86, and in x64 versions.
The version 0.10.17 is not the last, but nothing changed in this file from that 
release.
Thank you for the miranda development, it's a great messenger.

Original issue reported on code.google.com by sivanov...@gmail.com on 6 Nov 2013 at 11:14

[GoogleCodeExporter]

More than month has passed, with no reaction. Can it be, that there are no 
developers here? If this is the case, where else can I post this bug report?

Original comment by sivanov...@gmail.com on 9 Dec 2013 at 11:50

[GoogleCodeExporter]

Original comment by rainwater on 5 Apr 2014 at 7:50

[GoogleCodeExporter]

This issue was closed by revision r14463.

Original comment by rainwater on 5 Apr 2014 at 8:28

• Changed state: Fixed