ValentijnNK / miranda

Automatically exported from code.google.com/p/miranda
0 stars 0 forks source link

[Text] Another name within customize->sounds #945

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hello,
the main entry for sound notifications for IRC channels, Jabber Mucs, MSN 
Room,... in Customize->Sounds is "Chat".

Chat? Everything in Miranda is "Chat", not all users knows that this entry came 
from "chat.dll".

Suggestion: rename "Chat" in "Multiuser Chat"

regards
Peter

Original issue reported on code.google.com by Lastwebpage@gmail.com on 31 Aug 2010 at 9:45

GoogleCodeExporter commented 9 years ago

Original comment by alex.zif...@gmail.com on 31 Aug 2010 at 10:45

GoogleCodeExporter commented 9 years ago
I have done a patch to change it for Chat, TabSRMM and Scriver.
I changed the text to "Group Chats" because thats the name of the options page.
I also removed unneeded translations.

Original comment by wishmaster51 on 31 Aug 2010 at 12:15

GoogleCodeExporter commented 9 years ago
New patch: Instead of Translate I am using LPGEN to make it more 
translator-friendly :)

Original comment by wishmaster51 on 31 Aug 2010 at 12:25

GoogleCodeExporter commented 9 years ago

Original comment by sami%mir...@gtempaccount.com on 31 Aug 2010 at 7:31

GoogleCodeExporter commented 9 years ago
New patch:
-I renamed "Messages" to "Instant Messages", because group chat messages are 
messages as well (idea by Nightwish)

Original comment by wishmaster51 on 1 Sep 2010 at 10:28

GoogleCodeExporter commented 9 years ago
@wishmaster51: Nice.

Original comment by x696Nigh...@gmail.com on 1 Sep 2010 at 8:00

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Thanks :)

Since Nightwish changed it for TabSRMM in revision 12552, I am updating my 
patch to only patch Scriver, Chat and SRMM :)
Previous patches are obsolete

Original comment by wishmaster51 on 2 Sep 2010 at 12:48

GoogleCodeExporter commented 9 years ago
Would you mind? :)

Original comment by sami%mir...@gtempaccount.com on 2 Sep 2010 at 1:11

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r12629.

Original comment by borkra on 8 Sep 2010 at 2:01

GoogleCodeExporter commented 9 years ago
Oh it seems I might have made a stupid copy&paste mistake.. :(

The
SkinAddNewSoundEx("ChatSent", LPGEN("Group chats"), LPGEN("Outgoing message"));
was not there in Scriver and Chat before, so i dont know if it will ever be 
called, sorry :(

Would you mind commenting it out?

Original comment by wishmaster51 on 8 Sep 2010 at 8:04

GoogleCodeExporter commented 9 years ago
"ChatSent" is indeed tabsrmm-only - some users requested sound effects for 
outgoing messages in group chats...

Original comment by silverci...@gmail.com on 8 Sep 2010 at 8:28