Async ping support - Githubissues

JonasKs commented 3 years ago

Draft, up for suggestions or changes. Also feel free to close if you think this is out of scope.

Notes:

I've changed id to be packet_id to not shadow outer scope
I've changed socket to be named sock to not shadow outer scope
PID can not be used as an ID for async, a random.randint() or similar solution must be used. Can it be a string? Can we use uuid.uuid4().hex?
Uses IPv6Address builtin Python function from the ipaddress library instead of regex.

Utilizes asyncio.run_in_executor to make it awaitable.

Closes #24

ValentinBELYN commented 3 years ago

Thanks for the PR 👍 As I said in issue #23, the release of the version 2.0 is near. So, I put it aside for the next major release.

JonasKs commented 3 years ago

Closed. See #23 for reasoning. I'll update there whenever I release a asyncio library built on this icmplib.

ValentinBELYN / icmplib