Add a parameter to define the first TTL for traceroute

scoulondre commented 3 years ago

Hi, just made this small improvement that's very useful for me. Just in case, you would like to include it too. Best regards Stephane

ValentinBELYN commented 3 years ago

Hi! Good idea! Thank you 😄

However, there are several things to correct:

I'm not sure it is a good idea to add it to the examples. Currently, they include only some library features. The examples show how to use the classes, methods and functions provided by the library. The parameter you want to add is not useful for understanding.
The README file should not be changed until a new version is released. Otherwise, a developer can try to use a feature that is not available in the latest version (on PyPI). In addition, I am working on it to prepare the next release of version 2.0.
Finally, how about using the name first_hop instead of min_hops?

scoulondre commented 3 years ago

You're welcome. I just cancelled the example and the README, and renamed the parameter as first_hop.

ValentinBELYN commented 3 years ago

Thanks 👍

ValentinBELYN / icmplib