ValentinBELYN / icmplib

Easily forge ICMP packets and make your own ping and traceroute.
GNU Lesser General Public License v3.0
276 stars 46 forks source link

Add TTL support and payload customization #3

Closed leo-liu closed 4 years ago

leo-liu commented 4 years ago
ValentinBELYN commented 4 years ago

Thank you for your contribution 👍 If I totally agree with the addition of the TTL, I am divided on the fact of being able to customize the content of the payload. Do you actually have a use case for this?

leo-liu commented 4 years ago

Customizing payloads is useful, although unusual. The payload in current icmplib is totally random, while most implementations use a static pattern.

What's more, the ICMP payload may include an additinal timestamp, which is an optional feature implemented by, for example, Liunx. It is a useful feature for testing. As a simple library, a customizable payload makes it possible to implement such extensions.

ValentinBELYN commented 4 years ago

I just released a new version of icmplib (v1.0.3) which adds the ability to customize the payload, as well as other values.