ValentinBELYN / icmplib

Easily forge ICMP packets and make your own ping and traceroute.
GNU Lesser General Public License v3.0
266 stars 46 forks source link

Actual license is unclear: is it LGPLv3 or LGPLv3+? #72

Closed rominf closed 9 months ago

rominf commented 9 months ago

I am reviewing Fedora package introduction for your library (https://bugzilla.redhat.com/show_bug.cgi?id=2237913).

I found that the PyPI license classifier: https://github.com/ValentinBELYN/icmplib/blob/95994f6b4c4a00010cb96854b28bc097370c4070/setup.cfg#L20 says it's LGPLv3+, while in README: https://github.com/ValentinBELYN/icmplib/blob/95994f6b4c4a00010cb96854b28bc097370c4070/README.md?plain=1#L637 it's written that the license is LGPLv3.

Analysis of comments in files also doesn't give clarity:

GNU Lesser General Public License v3.0 or later                                                                                                                
-----------------------------------------------                                                                                                                
icmplib-3.0.3/icmplib/__init__.py                                                                                                                              
icmplib-3.0.3/icmplib/exceptions.py                                                                                                                            
icmplib-3.0.3/icmplib/models.py                                                                                                                                
icmplib-3.0.3/icmplib/multiping.py                                                                                                                             
icmplib-3.0.3/icmplib/ping.py                                                                                                                                  
icmplib-3.0.3/icmplib/sockets.py                                                                                                                               
icmplib-3.0.3/icmplib/traceroute.py                                                                                                                            
icmplib-3.0.3/icmplib/utils.py                                                                                                                                 
icmplib-3.0.3/setup.py                                                                                                                                         

GNU Lesser General Public License, Version 3                                                                                                                   
--------------------------------------------                                                                                                                   
icmplib-3.0.3/LICENSE                                                                                                                                          
icmplib-3.0.3/README.md                                                                                                                                        
icmplib-3.0.3/examples/broadcast_ping.py                                                                                                                       
icmplib-3.0.3/examples/multiping.py                                                                                                                            
icmplib-3.0.3/examples/ping.py                                                                                                                                 
icmplib-3.0.3/examples/traceroute.py                                                                                                                           
icmplib-3.0.3/examples/verbose_ping.py                                                                                                                         
icmplib-3.0.3/examples/verbose_traceroute.py

Could you please make licensing information consistent?

ValentinBELYN commented 9 months ago

Hi @rominf,

All the files are licensed under LGPLv3. An error has indeed crept into the setup.cfg file. I just fixed it on GitHub. I will publish a new version of on PyPI this week.

I close this issue, thank you for reporting it 👍