search

ValentinFrancois / python-gitlab-submodule

List project submodules and get the commits they point to with python-gitlab
Apache License 2.0
3 stars 3 forks source link

[PATCH] Return None when the submodule commit is not contained in the diff #19

Closed darkdragon-001 closed 2 years ago

darkdragon-001 commented 2 years ago

I hit another limitation of the Gitlab API. In my case, the limit to generate diffs was at 1000 files changed in a single commit in my installation (probably default). I would prefer to return None in this case together with the successfully retrieved information like url instead of raising an exception as this will cause the whole iterator to fail.

ValentinFrancois commented 2 years ago

@darkdragon-001 makes sense, I added a warning log in that case. I also updated the README.md and added a test where I simulate such an incomplete diff.

Merging now

ValentinFrancois commented 2 years ago

version 0.2.1 released!

darkdragon-001 commented 2 years ago

You're the best! Thank you a lot for your timely response and active maintenance of this module!