Closed ValentinFrancois closed 2 years ago
Awesome! You code looks good and I tested it in my project without problems. Highly appreciate the addition of more tests!
Looks good to me and you can close my other PR when merging this one.
@darkdragon-001 wonderful, merging now
Version 0.1.5 released at https://pypi.org/project/python-gitlab-submodule/0.1.5/
@darkdragon-001 thank you for your contributions, I already merged the 2 small ones.
About parsing the URLs (https://github.com/ValentinFrancois/python-gitlab-submodule/pull/3), I thought I had tested the code with some relative submodules, but your PR clearly showed the need of more tests.
So I created https://gitlab.com/python-gitlab-submodule-test/test-projects and I'm now using it for automated tests. This revealed other issues in the parsing logic that should be fixed now.
This PR gathers your original fixes + mine. I also added some more optional args. Feel free to review it and if you agree I'll close the old one.