Add support for custom error messages (closes #9, closes #11)

ValentinH / jest-fail-on-console

Utility to make jest tests fail when console.error() or any other methods are used

MIT License

141 stars 20 forks source link

Add support for custom error messages (closes #9, closes #11) #12

Closed JCB-K closed 2 years ago

JCB-K commented 2 years ago

As discussed in #11 , this PR adds support for custom error message. I also changed the default error message and added mockImplementation there, which should close #9.

ValentinH commented 2 years ago

Thanks for this. As soon as I retrieve my admin rights (I left the ricardo-ch org) I'll merge this 🙈

KevinHerklotz commented 2 years ago

Let me know if you want me to merge it 😉

ValentinH commented 2 years ago

Yes, please go ahead @KevinHerklotz 🙏 ❤️ I'll do the version bump on NPM afterwards.

JCB-K commented 2 years ago

@KevinHerklotz could you cut a new version as well? I guess a commit like this needs to be done before @ValentinH can do the NPM release

ValentinH commented 2 years ago

Yes you are right 🙈 Sorry for the delay, I'll handle this access issue this week hopefully. Ultimately, this project will be transferred to my GitHub..

ValentinH commented 2 years ago

It was finally published as v2.2.0 ! Sorry for the delay 🙈