The "Test did not tear down" check logic has been a source of problems recently. This check was in place to ensure that some code in a test could not disable the whole failOnConsole() logic for the other tests. This was actually obsolete since #5 since we are now resetting the mechanism before each test: if one test somehow disables it, it will be enabled again in the next test.
While digging again in this code, I now understand that having the fail on console mechanism enabled in a beforeEach() and disabled in a afterEach() allows to simplify quite a lot the original logic. This is what this PR is about.
The code in this PR is published as 2.2.2-alpha.0 if you want to try it.
Fix #13
The "Test did not tear down" check logic has been a source of problems recently. This check was in place to ensure that some code in a test could not disable the whole
failOnConsole()
logic for the other tests. This was actually obsolete since #5 since we are now resetting the mechanism before each test: if one test somehow disables it, it will be enabled again in the next test.While digging again in this code, I now understand that having the fail on console mechanism enabled in a
beforeEach()
and disabled in aafterEach()
allows to simplify quite a lot the original logic. This is what this PR is about.The code in this PR is published as
2.2.2-alpha.0
if you want to try it.