search

ValentinH / jest-fail-on-console

Utility to make jest tests fail when console.error() or any other methods are used
MIT License
141 stars 20 forks source link

Respond to PR Feedback #18

Closed doug-wade closed 2 years ago

doug-wade commented 2 years ago

@FloEdelmann left some great feedback on https://github.com/ValentinH/jest-fail-on-console/pull/15#pullrequestreview-930423021 after the PR was merged. This addresses that feedback.

doug-wade commented 2 years ago

I made an example project if you'd like to test this: https://github.com/doug-wade/jest-fail-on-console-client

ValentinH commented 2 years ago

Thanks for this fix. I actually just merged a PR that added the missing methods to the documentation so could you please rebase your PR and adjust accordingly ? 🙂

ValentinH commented 2 years ago

Fix published in https://github.com/ValentinH/jest-fail-on-console/releases/tag/v2.4.1