search

ValentinH / jest-fail-on-console

Utility to make jest tests fail when console.error() or any other methods are used
MIT License
146 stars 21 forks source link

Jest 28 compatability #21

Closed sklawren closed 2 years ago

sklawren commented 2 years ago

Please do a major version (semver) update to set devDependencies to Jest 28.

ValentinH commented 2 years ago

I'm actually wondering: why do you need this package to update its devDependencies? These dependencies should not impact the package users. jest-fail-on-console actually has no dependency nor peer dependency on Jest so it should not impact your Jest 28 update.

sklawren commented 2 years ago

For some reason, I was getting complaints from npm about dependency clashes but they seemed to have disappeared now that I tried it again.

ValentinH commented 2 years ago

I updated Jest on one of my projects yesterday and there was no issue related to this package. I'll probably update Jest on this package but I will not do a major version update as dev dependencies should not impact it.

ValentinH commented 2 years ago

Closing as we couldn't confirm there was a real issue linked to this package. Please comment if need to reopen.