search

ValentinH / jest-fail-on-console

Utility to make jest tests fail when console.error() or any other methods are used
MIT License
141 stars 20 forks source link

Typecheck error in `index.d.ts` #22

Closed kirill-galimov-plutotv closed 2 years ago

kirill-galimov-plutotv commented 2 years ago

There is a typecheck error in index.d.ts file.

"jest-fail-on-console": 2.4.1 "typescript": 4.5.5

  errorMessage?: (
    methodName: 'assert' | 'debug' | 'error' | 'info' | 'log' | 'warn',
    bold: (string) => string // Parameter has a name but no type. Did you mean 'arg0: string'?
  ) => string

image

ValentinH commented 2 years ago

Good catch, would you like to submit a PR to fix it?

KirillGalimov commented 2 years ago

@ValentinH I can submit a PR to fix it, how can I get permissions?

ValentinH commented 2 years ago

You just have to fork this repository, make the changes there and submit a PR. I think you could even do it by editing the right file from Github UI

KirillGalimov commented 2 years ago

@ValentinH thanks! done.

ValentinH commented 2 years ago

Fixed by #23