search

ValentinH / react-easy-crop

A React component to crop images/videos with easy interactions
https://valentinh.github.io/react-easy-crop/
MIT License
2.33k stars 167 forks source link

Allow lenient dependency on tslib #534

Closed aqeelat closed 6 months ago

aqeelat commented 6 months ago

tslib version in package.json is 2.0.1. Is there a specific reason why you're only allowing that version? Why not use ^2.0.1?

It's not causing me trouble but I was auditing my yarn.lock and I noticed that I have two versions of tslib installed.

ValentinH commented 6 months ago

No, I don't see any reason for this. Would you like doing a PR?

aqeelat commented 6 months ago

Hi @ValentinH. Thank you for the prompt response. I'll open the PR soon. I also see some other dev dependencies that are outdated. Maybe you'd want to look at them.

Screenshot 2024-05-02 at 12 26 47 PM
ValentinH commented 6 months ago

Thanks for the PR. I'll review it shortly.

Regarding outdated dev deps, I'm aware of them but it's hard to keep up with all of them. I'm really focusing on non-dev deps as they are the ones that matter for people using this lib. Dev deps are implementation details that only matter to contributors.

github-actions[bot] commented 6 months ago

:rocket: Issue was released in v5.0.7 :rocket: