ValentinH / react-easy-crop

A React component to crop images/videos with easy interactions
https://valentinh.github.io/react-easy-crop/
MIT License
2.34k stars 167 forks source link

Rotation via touch input doesn't work on chrome or firefox #565

Open mightym opened 2 months ago

mightym commented 2 months ago

Describe the bug Google Chrome Version 128.0.6613.138 (Offizieller Build) (arm64) Firefox Version 130.0.1 (64-Bit)

The rotation feature via touch input doesn't work for me on chrome and firefox on MacOs. Zooming via pinch works everywhere for me. Zooming and rotating works for me only in safari.

To Reproduce Steps to reproduce the behavior:

Use Chrome on MacOs (latest version) and try to rotate your example https://codesandbox.io/p/sandbox/y09komm059?file=%2Fsrc%2Findex.js%3A81%2C15-81%2C45

Expected behavior I expected that the rotation would work on touch inputs

ValentinH commented 2 months ago

When talking about "touch input" on MacOS, are you referring to the gestures on the trackpad?

mightym commented 2 months ago

@ValentinH Sorry yes. The pinch gesture works to zoom in. But twisting your fingers to rotate the image works for me only on safari.

ValentinH commented 2 months ago

Unfortunately this is because the trackpad gestures are fired using a non-standard gesturestart event that is only implemented on Apple browsers.