search

ValentinH / react-easy-sort

A React component to sort items in lists or grids
https://ValentinH.github.io/react-easy-sort
MIT License
160 stars 25 forks source link

GH-page not published #1

Closed raed667 closed 3 years ago

raed667 commented 3 years ago

Describe the bug

The NPM linked GitHub page ricardo-ch.github.io/react-easy-sort/ returns a 404

To Reproduce Steps to reproduce the behavior:

  1. Go to https://www.npmjs.com/package/react-easy-sort
  2. Click on Homepage
  3. See 404 error

Expected behavior

To see the GitHub page.

ValentinH commented 3 years ago

Good catch! 😅 This is a bad copy paste when initialising the project.

No there are 2 solutions:

raed667 commented 3 years ago

Either a storybook or a very basic landing page/demo.

Whatever is simpler.

ValentinH commented 3 years ago

Yes bot are fine to me. Would you like to do a PR? 😄

raed667 commented 3 years ago

Sure thing, but probably not before Friday

ValentinH commented 3 years ago

Awesome 🎉 Do you plan to use storybook or a simple page?

I think I would prefer a storybook as it's easier to maintain. Otherwise, we could create a page similar to https://ricardo-ch.github.io/react-easy-crop. However, using Next instead of Gatsby 😋

raed667 commented 3 years ago

Maybe just a storybook to start, I don't think the 2 are very different in terms of effort, I just would rather not to have to think about design 😄

raed667 commented 3 years ago

https://github.com/ricardo-ch/react-easy-sort/pull/2