Support knobs - Githubissues

ValentinH / react-easy-sort

A React component to sort items in lists or grids

https://ValentinH.github.io/react-easy-sort

MIT License

160 stars 25 forks source link

Support knobs #16

Closed phaistonian closed 3 years ago

phaistonian commented 3 years ago

This PR Closes #14

Notes:

I am not into TypeScript, so you might want to clean up the code a bit.
This target checking against the knobs should also be applied to the touch event - missed that.
README could also need an update.

https://user-images.githubusercontent.com/796530/124083708-dfb29f00-da56-11eb-9d42-bc3c74b1ddd5.mp4

phaistonian commented 3 years ago

As a side-note, for this to be more efficient in terms of performance, knobs should be promoted to a map and have knobs per item, i.e registerKnob = knobsMap.get(itemRef).push(knob).

It's not a biggie, but in super-huge lists, it might have some impact.

ValentinH commented 3 years ago

Thanks for this great contribution! This was released with https://github.com/ricardo-ch/react-easy-sort/releases/tag/v1.2.0.