search

ValentinH / react-easy-sort

A React component to sort items in lists or grids
https://ValentinH.github.io/react-easy-sort
MIT License
160 stars 25 forks source link

Fix unnecessary list rendering #19

Closed gtluszcz closed 3 years ago

gtluszcz commented 3 years ago

In my last PR I've made a simple mistake while rendering children of SortableList. I should have rendered single child instead of a list. This is an obvious post factum fix.

Current codebase results in warning Each child in a list should have a unique "key" prop. in the console.

ValentinH commented 3 years ago

Oups 😅 I actually saw it when doing my first review on the phone and then missed it 🙈

ValentinH commented 3 years ago

Fix published as v1.3.1

gtluszcz commented 3 years ago

Thanks for understanding! :D