search

ValentinH / react-easy-sort

A React component to sort items in lists or grids
https://ValentinH.github.io/react-easy-sort
MIT License
160 stars 25 forks source link

feat: add dropTarget feature #40

Closed RostiMelk closed 10 months ago

RostiMelk commented 10 months ago

First of all, thank you for this great package! It makes it super simple to create a simple draggable interfaces without the need for adding a ton of boilerplate code.

PR Description

The idea is to add a placeholder, which would occupy the space of the available target position while dragging an item. This would make it easier to see where the item would be placed, when dropping it.

This is a non-breaking change, as the placeholder is only added when the placeholder prop is set.

Preview

https://github.com/ValentinH/react-easy-sort/assets/25268506/59821aba-2b33-4da9-95f2-eedb3d99d903

PR Checklist

Would love to hear your thoughts on this, and the API for this feature!

ValentinH commented 10 months ago

Hi! That looks like a nice feature, thanks!

Sorry for the delay, I don't have much time to allocate to this project these days, I'll try my best to review this ASAP.

RostiMelk commented 10 months ago

Hi! That looks like a nice feature, thanks!

Sorry for the delay, I don't have much time to allocate to this project these days, I'll try my best to review this ASAP.

No worries! I just pushed a commit to the PR that solves all your comments :) Thanks for taking the time 🙏

ValentinH commented 10 months ago

Thank you, this is released ! https://github.com/ValentinH/react-easy-sort/releases/tag/v1.6.0