search

ValentinH / svelte-easy-crop

A Svelte component to crop images with easy interactions
https://codesandbox.io/s/svelte-easy-crop-basic-demo-q1005?file=/App.svelte
MIT License
199 stars 31 forks source link

chore: bump sveltekit to v2 along with its dependencies #50

Closed Davidonium closed 9 months ago

Davidonium commented 9 months ago

Tried using this library and since I recently bumped my project to sveltekit v2 I saw a warning, as seen in the issue https://github.com/ValentinH/svelte-easy-crop/issues/49.

This PR tries to solve the warning.

In the PR:

  1. There are bumps to @svelteks/kit v2 and its surrounding dependencies. (The svelte 3 to 4 bump required some additional work on the setup of eslint).
  2. Adds tabindex and role=button to avoid aria warnings to a div that was raising them.
  3. Fixes package publishing so that dependants on this package don't receive this warning: https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#missing-exports-condition

I would need some help with the version bumping on the actual library. Also the e2e tests are failing because there's a small difference of subpixels in the image sizes.

Not sure how you work but I am open to change anything, hope this helps maintain the library.

socket-security[bot] commented 9 months ago

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@sveltejs/vite-plugin-svelte 3.0.1 environment +66 269 MB svelte-admin
eslint-plugin-svelte 2.35.1 filesystem +36 8.61 MB ota-meshi
@sveltejs/kit 1.3.2...2.0.6 None +72/-50 269 MB svelte-admin
vite 4.0.4...5.0.10 None +41/-31 262 MB vitebot
@sveltejs/adapter-auto 1.0.2...3.0.1 None +74/-52 269 MB svelte-admin
vitest 0.28.3...1.1.0 shell +78/-71 267 MB oreanno
@sveltejs/package 1.0.2...2.2.4 None +23/-3 39.1 MB svelte-admin
@typescript-eslint/eslint-plugin 5.49.0...6.15.0 None +17/-17 38.5 MB jameshenry
@typescript-eslint/parser 5.49.0...6.15.0 None +9/-9 33.9 MB jameshenry
svelte 3.55.1...4.2.8 None +19/-0 6.27 MB svelte-admin
prettier-plugin-svelte 2.9.0...2.10.1 None +20/-1 6.54 MB dummdidumm
svelte-check 3.0.3...3.6.2 None +27/-9 47.9 MB svelte-language-tools-deploy
typescript 4.9.4...5.3.3 None +0/-0 32 MB typescript-bot

🚮 Removed packages: eslint-plugin-svelte3@4.0.0

ValentinH commented 9 months ago

Thank you for taking the time to submit this PR. 🎉

ValentinH commented 9 months ago

Published as svelte-easy-crop@2.0.2 🎉