search

ValentinaPanetta / ColmarAcademy

capstone project
0 stars 0 forks source link

Summary #4

Open thecodeduchess opened 6 years ago

thecodeduchess commented 6 years ago

Grade: Meets Expectations

Summary: This was a great implementation of the project. First, I test your project by downloading it and viewing it in my own browser. Next, I go step by step with your page against the requirements. It matches to my specs exactly. After nitpicking through it, I did not find anything that requires a re-do. What I check for is code quality and how closely you can match to the spec.

The code was easily readable and met the required styling, class and ID naming. If you want to build onto this project or future projects, you could consider adding a border on some of the elements, changing the font design, background color or use other various font colors (I saw you added a little bit). Don't be afraid to experiment. You can make it your own for an exceeding expectations grade.

I hope you are enjoying your learning experience. You are certainly ready to move on to the next step!

ValentinaPanetta commented 6 years ago

Thank you for your review. I'm not entirely sure on what you mean by "making it my own for an exceeding expectations grade". Are you suggesting that I submit it again? And if so, how does the grade influence on my completion of the course? Furthermore, I tried to stay true to the spec regarding my design choices, so that I would not deviate from the concept too much, I didn't know I experiment more.

thecodeduchess commented 6 years ago

No I just meant you can also add a personal touch. You do not need to resubmit. It does not affect completion o the course.

On Thursday, December 21, 2017, Cosmic0wl notifications@github.com wrote:

Thank you for your review. I'm not entirely sure on what you mean by "making it my own for an exceeding expectations grade". Are you suggesting that I submit it again? And if so, how does the grade influence on my completion of the course? Furthermore, I tried to stay true to the spec regarding my design choices, so that I would not deviate from the concept too much, I didn't know I experiment more.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Cosmic0wl/ColmarAcademy/issues/4#issuecomment-353347863, or mute the thread https://github.com/notifications/unsubscribe-auth/AIUaFtZVTWzi1NVdfhu8mGaX5YDTQ_Ryks5tClm_gaJpZM4RIwzZ .

-- Tell me and I forget. Show me and I remember. Involve me and I understand.