ValeraT1982 / ObjectsComparer

C# Framework provides mechanism to compare complex objects, allows to override comparison rules for specific properties and types.
MIT License
352 stars 86 forks source link

NuGet packages not strong named #34

Open adancy opened 2 years ago

adancy commented 2 years ago

I don't know if this is just the latest version, but when trying to use the NuGet packages for ObjectsComparer they do not appear to be strongly named. This means we're not able to use the library without having to either manually re-sign the package, or download from source and compile. Any chance packages could be strongly named going forward?

ValeraT1982 commented 2 years ago

Can you please provide the text of the error? "we're not able to use the library without having to either manually re-sign the package" is it because of some specific settings of your project?

adancy commented 2 years ago

It's because our own app is strong name signed, and that then requires all referenced libraries to also be strong named (see https://docs.microsoft.com/en-us/dotnet/standard/assembly/strong-named)

The specific error is "Assembly generation failed -- Referenced assembly 'ObjectsComparer' does not have a strong name"

For now we've worked around it by recompiling the library with strong name enabled so this isn't urgent.

ValeraT1982 commented 2 years ago

Thanks for the additional info. I'll have a look.