Valerioageno / tuono

Superfast fullstack React framework
https://tuono.dev
MIT License
198 stars 11 forks source link

chore: add `examples` folder to workspaces and make examples packages name unique #125

Closed marcalexiei closed 6 days ago

marcalexiei commented 6 days ago

Context & Description

Followup of "Tokio-runtime-worker issue" Discord thread

This PR aims to handle the examples folder node_modules folder without using —ignore-workspace.

Adding them to pnpm workspace creates a node_modules folder with symbolic links that should prevent the Tokio-runtime-worker error when running turbo cli within these folders.

[!TIP] This should completely remove the need of independent node installation across packages simplifying project setup procedure.


Examples folder renames

Also examples folder have renamed

[!NOTE] No problem changing them to something different. My only concern is that they should be unique in the future scenario where they can be involved inside a turbo pipeline.

According to the previous renames crates/tuono/src/scaffold_project.rs#create_new_project has been updated to tuono-app as default value for template CLI argument.

Valerioageno commented 6 days ago

No problem changing them to something different. My only concern is that they should be unique in the future scenario where they can be involved inside a turbo pipeline.

What is the future scenario you see with them involved in turbo?

marcalexiei commented 6 days ago

Maybe this doesn't have sense since these are very simple examples but just to want to point this out 🙂.

Valerioageno commented 6 days ago

Yeah, makes sense. We don't know yet but better safer than sorry either way!