ValhallaTeam / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

#line arguments not macro expanded in direct contradiction of spec #183

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. run $ echo "#define L 666 7
#line L
void main() { return 0; } // error on line 666, file 7" > line_macro.frag
2. run $ essl_to_glsl line_macro.frag

What is the expected output? What do you see instead?
It is expected that the main function's error is reported on line 666 of unit 7

Instead, an error is reported on the spec-conforming #line directive and 
subsequently the line-counting is wrong for the void-function-returning-value 
error. See page 15 of the public spec: 
http://www.khronos.org/registry/gles/specs/2.0/GLSL_ES_Specification_1.0.17.pdf

What version of the product are you using? On what operating system?
r705 on OS X 10.6

Please provide any additional information below.

Google claims to ship a "conformant" WebGL implementation.

Google's implementation is demonstrably not conformant and by continuing to 
claim it is conformant, Google is doing damage to the "good will" and 
"reputation" the "public" has come to expect from the WebGL mark.

Of course, if the tens of thousands of dollars Google pays to have access to 
conformance tests and "certification" by the official Khronos body may not 
actually be about conformance... perhaps it's just a way to justify 
intellectually dishonest "openness" while still acting like a protectionistic 
industrial trust?

And no, forcing free-level implementers to agree to a contract that limits 
their speech to access a conformance test suite is not "open".

Original issue reported on code.google.com by kosmo...@gmail.com on 15 Jul 2011 at 10:33

GoogleCodeExporter commented 9 years ago
http://code.google.com/p/angleproject/source/detail?r=718

Hooray! Thank you, Googlers and Transgamers!

Original comment by kosmo...@gmail.com on 9 Aug 2011 at 12:26

GoogleCodeExporter commented 9 years ago
The old preprocessor has been replaced with a completely rewritten one.  This 
issue should no longer be a problem. 

Original comment by dan...@transgaming.com on 26 Oct 2012 at 7:34