ValhallaTeam / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

ANGLE returns wrong names for arrays of structure uniforms #367

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Go to 
https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/misc/shader-wi
th-array-of-structs-uniform.html

What is the expected output? 

It should pass

What do you see instead?

It fails

Checking the code it should be returning

u_colors[0].color1
u_colors[0].color2
u_colors[1].color1
u_colors[1].color2

as the 4 uniform names but it's returning

u_colors[0].color1[0]
u_colors[0].color2[0]
u_colors[1].color1[0]
u_colors[1].color2[0]

Even though color1 and color2 are not arrays

Original issue reported on code.google.com by g...@google.com on 5 Sep 2012 at 10:00

GoogleCodeExporter commented 9 years ago
I was suspicious of my recent change in r1267 but I don't think that's it. The 
conformance test fails the same way in beta as well, which is based off r1046. 
I think it might have something to do with Uniform::isArray returning true for 
decorated names starting "ar_" and always appending a "[0]" but I haven't dug 
very deep.

Original comment by apatr...@chromium.org on 5 Sep 2012 at 10:24

GoogleCodeExporter commented 9 years ago

Original comment by nicolas....@gmail.com on 23 Sep 2012 at 7:03

GoogleCodeExporter commented 9 years ago
This should be fixed in r1285.

Original comment by dan...@transgaming.com on 27 Sep 2012 at 5:53