ValhallaTeam / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Have ANGLE's shader validator optionally enforce packing restrictions #373

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The GLSL spec 1.017, Appendix A, Section 7 specifies a packing algorithm.

It would be good to be able to enforce this restriction, passing a flag into 
ShConstructCompiler or whatever

a) it could be used to force developers not to count on perfectly optimizing 
drivers. If 2 drivers have a limit of X uniforms and the user uses X+1 uniforms 
the shader may pass on one driver but not the other

b) some drivers don't enforce restrictions well

For example, some drivers will compile this, others won't

   uniform vec4 lotsOfUniforms[10000000];
   void main () {
     gl_Position = lotsOfUniforms[0];
   }

Original issue reported on code.google.com by g...@chromium.org on 4 Oct 2012 at 7:32

GoogleCodeExporter commented 9 years ago

Original comment by g...@chromium.org on 4 Oct 2012 at 7:32

GoogleCodeExporter commented 9 years ago
For various reasons I'm going to say this is high priority.

Original comment by kbr@chromium.org on 4 Oct 2012 at 7:36

GoogleCodeExporter commented 9 years ago

Original comment by kbr@chromium.org on 4 Oct 2012 at 7:36

GoogleCodeExporter commented 9 years ago
Here's a CL.
https://codereview.appspot.com/6652051/

Original comment by g...@chromium.org on 12 Oct 2012 at 1:22

GoogleCodeExporter commented 9 years ago

Original comment by geofflang@chromium.org on 10 Dec 2013 at 3:50

GoogleCodeExporter commented 9 years ago
Don't we support packing restrictions now?

Original comment by jmad...@chromium.org on 5 May 2014 at 2:26

GoogleCodeExporter commented 9 years ago
Was implemented by https://codereview.appspot.com/6652051/

Original comment by c...@chromium.org on 21 May 2014 at 6:27