MapLongVariableNames.cpp does not compile with -Wshorten-64-to-32

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Compile ANGLE with clang with -Wshorten-64-to-32 warning enabled.

What is the expected output? What do you see instead?
Expected no warnings.  Got warnings.

What version of the product are you using? On what operating system?
ANGLE r1641 merged into the WebKit project.

Please provide any additional information below.

Source/ThirdParty/ANGLE/src/compiler/MapLongVariableNames.cpp:79:12: error: 
implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') 
to 'int' [-Werror,-Wshorten-64-to-32]
    return mLongNameMap.size();
    ~~~~~~ ^~~~~~~~~~~~~~~~~~~
1 error generated.

The method looks like this:

int LongNameMap::Size() const
{
    return mLongNameMap.size();
}

If mLongNameMap isn't expected to get bigger than 
std::numeric_limits<int>::max(), then it should use a static_cast<int>() 
operator.  It's possible to change mapLongName() in MapLongVariableNames.cpp to 
take a size_t instead of an int, but every other caller of mapLongName() passes 
an int already.

Original issue reported on code.google.com by ddkilzer@gmail.com on 27 Jan 2013 at 2:53

[GoogleCodeExporter]

Original comment by kbr@chromium.org on 7 Feb 2013 at 1:13

[GoogleCodeExporter]

Original comment by kbr@chromium.org on 7 Feb 2013 at 1:31

• Changed state: Started

[GoogleCodeExporter]

Fixed in https://code.google.com/p/angleproject/source/detail?r=1826 .

Original comment by kbr@chromium.org on 12 Feb 2013 at 3:10

• Changed state: Fixed