Input.cpp does not compile with -Wshorten-64-to-32

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Compile ANGLE with clang with -Wshorten-64-to-32 warning enabled.

What is the expected output? What do you see instead?
Expected no warnings.  Got warnings.

What version of the product are you using? On what operating system?
ANGLE r1641 merged into the WebKit project.

Please provide any additional information below.

Source/ThirdParty/ANGLE/src/compiler/preprocessor/Input.cpp:33:37: error: 
implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 
'value_type' (aka 'int') [-Werror,-Wshorten-64-to-32]
        mLength.push_back(len < 0 ? std::strlen(mString[i]) : len);
                                  ~ ^~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

This happens because mLength is defined as:

    std::vector<int> mLength;

Probably need to do some bounds checking on std::strlen(mString[i]) before 
truncating it with a static_cast<int>().

Original issue reported on code.google.com by ddkilzer@gmail.com on 27 Jan 2013 at 3:36

[GoogleCodeExporter]

See also Issue 408.

Original comment by ddkilzer@gmail.com on 27 Jan 2013 at 10:16

[GoogleCodeExporter]

Original comment by kbr@chromium.org on 7 Feb 2013 at 1:14

[GoogleCodeExporter]

Original comment by kbr@chromium.org on 7 Feb 2013 at 1:31

• Changed state: Started

[GoogleCodeExporter]

Fixed in https://code.google.com/p/angleproject/source/detail?r=1826 .

Original comment by kbr@chromium.org on 12 Feb 2013 at 3:10

• Changed state: Fixed