Valian / docker-nginx-auto-ssl

Docker image for automatic generation of SSL certs using Let's encrypt and Open Resty
https://hub.docker.com/r/valian/docker-nginx-auto-ssl/
MIT License
411 stars 103 forks source link

Example ALLOWED_DOMAINS in README #1

Closed serathius closed 6 years ago

serathius commented 6 years ago

I would propose better domain regexp as one presented in README .*example.com could match any-example.com or suffix that really does not fit domain based hierarchy. Usually people would use exact domains and subdomains, or wildcard. domain ALLOWED_DOMAINS=example.com subdomains ALLOWED_DOMAINS=(www|api).example.com wildcard ALLOWED_DOMAINS=([a-z]+.)?example.com Also it would be good to explain how lua handles unicode strings. From http://lua-users.org/wiki/LuaUnicode you can get that it would be better to replace .* with [a-z]+

Valian commented 6 years ago

Thanks @serathius, it's fixed