Closed timothestes closed 1 year ago
Proposed code changes to resolve this issue.
@timothestes thanks for raising this and for the proposed fix. I'll review your PR at the weekend.
Amazing! Thank you so much!
I'll clean up the unnecessary dep and release the new version tonight/sometime tomorrow. Thanks a lot for taking the time to fix this!
That's done, your fix is in 0.1.6
.
Summary
If a dash is contained in the user's aws domain name, partifact has trouble parsing the url correctly.
Steps to Reproduce
Put this in
pyproject.toml
file:Then run this command: partifact login aws
In this scenario, the rules that are parsing the source url are parsing the
code_artifact_domain
asmy
(instead ofmy-domain
), and theaws_account
asdomain-123456789012
(instead of123456789012
)Expected behavior:
The following url would be parsed as such:
Actual Behavior:
The following url is parsed as such: