search

Valkirie / HandheldCompanion

ControllerService
Other
1.16k stars 91 forks source link

Custom overlay option for battery is not hidden when setting level to disabled #1055

Closed CasperH2O closed 4 months ago

CasperH2O commented 4 months ago

Handheld Companion Version 0.21.1.0

Describe the bug Adjusting OSD Custom level settings for battery to Disabled does not hide it.

Also, when adjusting the value in the main GUI, the QT GUI does not reflect the same level, this does work for VRAM level and the other options.

Traced the code a bit, viewmodel stuff is set, but actual settings file is never updated.

This can't be good in user.config:

    <setting name="OnScreenDisplayBATTLevel" serializeAs="String" value="2" />
    <setting name="OnScreenDisplayBatteryLevel" serializeAs="String" value="2" />

To Reproduce Adjust level for the custom OSD for battery to Disabled from Full when visible in a game

CasperH2O commented 4 months ago

Fixed with Valkirie/HandheldCompanion-EA#263 turned out the datatype for this settings entry was set to String instead of Int. Also removed an old battery left over.