Valkirie / HandheldCompanion

ControllerService
Other
1.2k stars 92 forks source link

Add 80% battery charge limit for Legion Go #1074

Closed moyogii closed 5 months ago

moyogii commented 5 months ago

Adds 80% battery charge limit toggle for the Legion Go.

Initially, I was trying to do this through a function located in the SapientiaUSB.dll but I was unable to find anything of use. I did however find out through another project (LegionGoRemapper) that 0x03010001 handles the enabling or disabling of the 80% battery charge limit.

If there is an alternative way of doing this that makes more sense, please let me know!

image

Summary by CodeRabbit

coderabbitai[bot] commented 5 months ago

Walkthrough

The recent changes introduce a new feature to set a battery charge limit for Lenovo Legion devices within the HandheldCompanion application. This involves adding a new setting, UI components, and methods to handle the battery charge limit functionality. Additionally, a new name "PlasmidEve" was added to the AboutPage.

Changes

Files Change Summary
HandheldCompanion/App.config, HandheldCompanion/Properties/Settings.settings Added LegionBatteryChargeLimit setting with default False.
HandheldCompanion/Devices/Lenovo/LegionGo.cs Added methods SetBatteryChargeLimit, UpdateSettings, and event handler SettingsManager_SettingValueChanged.
HandheldCompanion/Properties/Resources.Designer.cs, HandheldCompanion/Properties/Resources.resx Added localized strings for battery charge limit settings.
HandheldCompanion/Properties/Settings.Designer.cs Added public boolean property LegionBatteryChargeLimit with getter and setter.
HandheldCompanion/Views/Pages/AboutPage.xaml Added "PlasmidEve" to the list of names.
HandheldCompanion/Views/Pages/DevicePage.xaml Added Border element for battery charge limit feature with child elements.
HandheldCompanion/Views/Pages/DevicePage.xaml.cs Added method Toggle_LegionBatteryChargeLimit_Toggled to handle toggle switch state.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant DevicePage
    participant LegionGo
    participant SettingsManager

    User ->> DevicePage: Toggle Battery Charge Limit
    DevicePage ->> SettingsManager: Update Setting (LegionBatteryChargeLimit)
    SettingsManager ->> LegionGo: Notify Setting Changed
    LegionGo ->> LegionGo: UpdateSettings()
    LegionGo ->> LegionGo: SetBatteryChargeLimit(enabled)

Poem

In the land of code, a change took flight,
For Legion's charge, a limit set just right.
Eighty percent, the battery's goal,
To keep it healthy, to keep it whole.
With toggles and switches, the settings align,
HandheldCompanion, for a longer battery time.
And PlasmidEve joins the hall of fame,
In the AboutPage, forever in name. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Valkirie commented 5 months ago

Good job, merged