search

Valkirie / HandheldCompanion

ControllerService
Other
1.16k stars 91 forks source link

Special key not working properly with emulated DS4 controller #698

Closed trippyone closed 10 months ago

trippyone commented 1 year ago

Requirements:

How to replicate:

Press OEM1 key while Steam big picture is running. It should normally bring up the Steam navigation menu (like the Xbox guide button) but it's not. If you spam it, it will eventually show up. I did some investigation, it seems we are indeed injecting OEM1 key so I'm not sure what is the issue yet. I have attached my logs. logs.txt

trippyone commented 1 year ago

I traced the code up to the service when pressing the OEM1 key. It appears to be sending the correct key. Is it an issue on ViGEM level? image

trippyone commented 1 year ago

Key press delay is the source of the issue. Testing indicates that we need up to 150ms+ key press delay for it to be registered in apps such as Steam Big Picture. This is not necessary for Xbox controller, so I'll add logic based on controller type and key types.

trippyone commented 1 year ago

705

CasperH2O commented 10 months ago

Fixed by @trippyone in #705