search

Valkirie / HandheldCompanion

ControllerService
Other
1.15k stars 89 forks source link

Firmware update breaks OEM buttons #756

Closed MercerViruzX closed 1 year ago

MercerViruzX commented 1 year ago

ASUS ROG ALLY

Handheld Companinion Version 0.17.0.0.

After the firmware update the OEM buttons and back buttons do not work. Sometimes it registers as button 3 and long press, never as click. Tried to do a fresh install and reboot several times but to no avail.

madmatt30 commented 1 year ago

Managed after half a dozen attempts to get the right analog stick click in to register.

Can at least get the quick settings menu up with this button press now.

MercerViruzX commented 1 year ago

It seems like the new added feature in the firmware update messed up HHC. Is there a way to rollback the firmware update provided by Asus?

CasperH2O commented 1 year ago

Can confirm I also have this issue on my ROG Ally after updating the firmware.

My current suspect is HC not detecting or clearing the pressing of the back buttons once they have been pressed once (either one). Possible the OEM3 key is not released because the firmware changed the behavior of the back buttons. This might be a good thing as they had odd behavior to begin with. This line of code could no longer be called or requires a different condition: https://github.com/Valkirie/HandheldCompanion/blob/07d8e3885f11a40789c7eca658ab090fe19c2683/ControllerCommon/Devices/ASUS/ROGAlly.cs#L210

The workarounds I have found are not using the back buttons and or starting AC.

Will investigate, upcoming Friday at the earliest.

CasperH2O commented 1 year ago

Fixed with PR #757