Valkirie / HandheldCompanion

ControllerService
Other
1.16k stars 91 forks source link

Double inputs and 2 unmasked devices in hidhide conf #770

Open azodev opened 1 year ago

azodev commented 1 year ago

Device manufacturer

Device model Ally Handheld Companinion Version 0.18.0.1b

Describe the bug Double inputs are registered in games like baldurgate3, causing in this case splitscreen function to trigger cause the system has 2 devices unmasked.

To Reproduce Steps to reproduce the behavior: start hc. 2 devices detected and shown in hidhide start game like baldursgate 3 2 devices detected => splitscreen.

Expected behavior only 1 device unhidden in windows (the HC one) like in 0.17 version.

CasperH2O commented 1 year ago

Hey @azodev , thanks for reaching out. Can you share a screenshot of the HC controller page and a screenshot of the HidHide second tab?

azodev commented 1 year ago

does happens when the device wake from sleep, i'll try to reproduce it and do Screenshots, currently fixed it by closing HC, doing so removes the second device and hide the main one. I unhide in hidhide the main one. and relaunch HC and it seems ok. I think that the issue is again coming from sleep/wake.

azodev commented 1 year ago

I confirm, it's happening when putting the device in sleep (wait 5min, then) and waking it, there is 2 devices unmasked instead of one.

Capture d'écran 2023-08-29 140750

Capture d'écran 2023-08-29 140612
azodev commented 1 year ago

reproduce everytime time, put in sleep (normal) wake after 2 min 2 controllers are unmasked like in screen 1. Closing HC => remove 1 controller, and mask the last one (consequence => not visible anymore by other app) Need to manually unmask native controller then restart HC work ok after that till next sleep.

Deep Sleep (hibernate) seems to not cause the issue.

Valkirie commented 1 year ago

Folks, try this new build please, and report on changes. https://1drv.ms/u/s!AleMgLLgxwGJhZQNfzY-yWnb7LbzAQ?e=zezZE1

azodev commented 1 year ago

Its seems to work now. Thanks for the Quick fix!

Le mar. 29 août 2023, 19:05, Lesueur Benjamin @.***> a écrit :

Folks, try this new build please, and report on changes. https://1drv.ms/u/s!AleMgLLgxwGJhZQNfzY-yWnb7LbzAQ?e=zezZE1

— Reply to this email directly, view it on GitHub https://github.com/Valkirie/HandheldCompanion/issues/770#issuecomment-1697831200, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKHML5VQ4OQNTNQPJ6K7YH3XXYOOHANCNFSM6AAAAAA4CX2HSI . You are receiving this because you were mentioned.Message ID: @.***>

AleITDE1990 commented 1 year ago

Folks, try this new build please, and report on changes. https://1drv.ms/u/s!AleMgLLgxwGJhZQNfzY-yWnb7LbzAQ?e=zezZE1

Still an issue for me as it's not only present after waking up from sleep, instead it's always present.